Skip to content

Changes made for replacing io.prediction.* to org.apache.prediction… #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changes made for replacing io.prediction.* to org.apache.prediction… #21

wants to merge 1 commit into from

Conversation

@ishantanu
Copy link

@ishantanu ishantanu commented Nov 6, 2016

…io.*

Changes are made in build.sbt for replacing "io.prediction" with "org.apache.predictionio" and "core" with "apache-predictioio-core"
modified: build.sbt
modified: src/main/scala/DataSource.scala
modified: src/main/scala/Engine.scala
modified: src/main/scala/EsClient.scala
modified: src/main/scala/PopModel.scala
modified: src/main/scala/Preparator.scala
modified: src/main/scala/Serving.scala
modified: src/main/scala/URAlgorithm.scala
modified: src/main/scala/URModel.scala
modified: src/main/scala/package.scala

@ishantanu
Changes made for replacing io.prediction.* to org.apache.predictionio.*
144d634 
  Changes are made in build.sbt for replacing "io.prediction" with "org.apache.predictionio" and "core" with "apache-predictioio-core"
	modified:   build.sbt
	modified:   src/main/scala/DataSource.scala
	modified:   src/main/scala/Engine.scala
	modified:   src/main/scala/EsClient.scala
	modified:   src/main/scala/PopModel.scala
	modified:   src/main/scala/Preparator.scala
	modified:   src/main/scala/Serving.scala
	modified:   src/main/scala/URAlgorithm.scala
	modified:   src/main/scala/URModel.scala
	modified:   src/main/scala/package.scala
@pferrel
Copy link
Owner

pferrel commented Nov 6, 2016

great, thanks. I've done this too in a private branch. Are you able to run examples/integration-test successfully? Mine is failing in Datasource not finding data.

@ishantanu
Copy link
Author

ishantanu commented Nov 7, 2016

@pferrel Yup I tried integration tests. Here are the results :
Differences between expected and actual results, none is a passing test:
23c23

< {"itemScores":[{"item":"Iphone 4","score":0.18315871059894562},{"item":"Galaxy","score":0.18315871059894562},{"item":"Nexus","score":0.18315871059894562},{"item":"Ipad-retina","score":0.07201286405324936}]}

{"itemScores":[{"item":"Galaxy","score":0.18315871059894562},{"item":"Iphone 4","score":0.18315871059894562},{"item":"Nexus","score":0.18315871059894562},{"item":"Ipad-retina","score":0.07201286405324936}]}
31c31

< {"itemScores":[{"item":"Iphone 4","score":0.800000011920929},{"item":"Galaxy","score":0.800000011920929},{"item":"Nexus","score":0.0},{"item":"Ipad-retina","score":0.0}]}

{"itemScores":[{"item":"Galaxy","score":0.800000011920929},{"item":"Iphone 4","score":0.800000011920929},{"item":"Nexus","score":0.0},{"item":"Ipad-retina","score":0.0}]}
37c37

< {"itemScores":[{"item":"Galaxy","score":0.6802681088447571},{"item":"Nexus","score":0.3414953947067261},{"item":"Ipad-retina","score":0.06429719924926758},{"item":"Surface","score":0.013116735965013504}]}

{"itemScores":[{"item":"Galaxy","score":0.6802682280540466},{"item":"Nexus","score":0.34149542450904846},{"item":"Ipad-retina","score":0.06429719924926758},{"item":"Surface","score":0.013116735965013504}]}
41c41

< {"itemScores":[{"item":"Iphone 4","score":0.8768638968467712},{"item":"Galaxy","score":0.8768638968467712},{"item":"Nexus","score":0.23742027580738068},{"item":"Surface","score":0.04049335792660713}]}

{"itemScores":[{"item":"Galaxy","score":0.8768638968467712},{"item":"Iphone 4","score":0.8768638968467712},{"item":"Nexus","score":0.23742027580738068},{"item":"Surface","score":0.04049335792660713}]}
53c53

< {"itemScores":[{"item":"Iphone 4","score":0.4070388376712799},{"item":"Galaxy","score":0.4070388376712799},{"item":"Nexus","score":0.4070388376712799},{"item":"Ipad-retina","score":0.17534448206424713}]}

{"itemScores":[{"item":"Galaxy","score":0.4070388376712799},{"item":"Iphone 4","score":0.4070388376712799},{"item":"Nexus","score":0.4070388376712799},{"item":"Ipad-retina","score":0.17534448206424713}]}
59c59

< {"itemScores":[{"item":"Iphone 4","score":0.0},{"item":"Galaxy","score":0.0},{"item":"Nexus","score":0.0},{"item":"Ipad-retina","score":0.0}]}

{"itemScores":[{"item":"Galaxy","score":0.0},{"item":"Iphone 4","score":0.0},{"item":"Nexus","score":0.0},{"item":"Ipad-retina","score":0.0}]}
63c63

< {"itemScores":[{"item":"Iphone 4","score":0.0},{"item":"Galaxy","score":0.0},{"item":"Nexus","score":0.0},{"item":"Ipad-retina","score":0.0}]}

{"itemScores":[{"item":"Galaxy","score":0.0},{"item":"Iphone 4","score":0.0},{"item":"Nexus","score":0.0},{"item":"Ipad-retina","score":0.0}]}
67c67

< {"itemScores":[{"item":"Iphone 4","score":0.0},{"item":"Galaxy","score":0.0},{"item":"Nexus","score":0.0},{"item":"Ipad-retina","score":0.0}]}

{"itemScores":[{"item":"Galaxy","score":0.0},{"item":"Iphone 4","score":0.0},{"item":"Nexus","score":0.0},{"item":"Ipad-retina","score":0.0}]}
75c75

< {"itemScores":[{"item":"Nexus","score":0.9369767904281616},{"item":"Surface","score":0.6666666865348816},{"item":"Ipad-retina","score":0.204568549990654},{"item":"Iphone 4","score":0.0}]}

{"itemScores":[{"item":"Nexus","score":0.9369767904281616},{"item":"Surface","score":0.6666666865348816},{"item":"Ipad-retina","score":0.204568549990654},{"item":"Galaxy","score":0.0}]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ishantanu @pferrel